• Giovanni Gherdovich's avatar
    x86, sched: check for counters overflow in frequency invariant accounting · e2b0d619
    Giovanni Gherdovich authored
    The product mcnt * arch_max_freq_ratio can overflows u64.
    
    For context, a large value for arch_max_freq_ratio would be 5000,
    corresponding to a turbo_freq/base_freq ratio of 5 (normally it's more like
    1500-2000). A large increment frequency for the MPERF counter would be 5GHz
    (the base clock of all CPUs on the market today is less than that). With
    these figures, a CPU would need to go without a scheduler tick for around 8
    days for the u64 overflow to happen. It is unlikely, but the check is
    warranted.
    
    Under similar conditions, the difference acnt of two consecutive APERF
    readings can overflow as well.
    
    In these circumstances is appropriate to disable frequency invariant
    accounting: the feature relies on measures of the clock frequency done at
    every scheduler tick, which need to be "fresh" to be at all meaningful.
    
    A note on i386: prior to version 5.1, the GCC compiler didn't have the
    builtin function __builtin_mul_overflow. In these GCC versions the macro
    check_mul_overflow needs __udivdi3() to do (u64)a/b, which the kernel
    doesn't provide. For this reason this change fails to build on i386 if
    GCC<5.1, and we protect the entire frequency invariant code behind
    CONFIG_X86_64 (special thanks to "kbuild test robot" <lkp@intel.com>).
    
    Fixes: 1567c3e3 ("x86, sched: Add support for frequency invariance")
    Signed-off-by: default avatarGiovanni Gherdovich <ggherdovich@suse.cz>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Reviewed-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Link: https://lkml.kernel.org/r/20200531182453.15254-2-ggherdovich@suse.cz
    e2b0d619
topology.h 6.17 KB