• Chengguang Xu's avatar
    ext4: choose hardlimit when softlimit is larger than hardlimit in ext4_statfs_project() · 57c32ea4
    Chengguang Xu authored
    Setting softlimit larger than hardlimit seems meaningless
    for disk quota but currently it is allowed. In this case,
    there may be a bit of comfusion for users when they run
    df comamnd to directory which has project quota.
    
    For example, we set 20M softlimit and 10M hardlimit of
    block usage limit for project quota of test_dir(project id 123).
    
    [root@hades mnt_ext4]# repquota -P -a
    *** Report for project quotas on device /dev/loop0
    Block grace time: 7days; Inode grace time: 7days
                            Block limits                File limits
    Project         used    soft    hard  grace    used  soft  hard  grace
    ----------------------------------------------------------------------
     0        --      13       0       0              2     0     0
     123      --   10237   20480   10240              5   200   100
    
    The result of df command as below:
    
    [root@hades mnt_ext4]# df -h test_dir
    Filesystem      Size  Used Avail Use% Mounted on
    /dev/loop0       20M   10M   10M  50% /home/cgxu/test/mnt_ext4
    
    Even though it looks like there is another 10M free space to use,
    if we write new data to diretory test_dir(inherit project id),
    the write will fail with errno(-EDQUOT).
    
    After this patch, the df result looks like below.
    
    [root@hades mnt_ext4]# df -h test_dir
    Filesystem      Size  Used Avail Use% Mounted on
    /dev/loop0       10M   10M  3.0K 100% /home/cgxu/test/mnt_ext4
    Signed-off-by: default avatarChengguang Xu <cgxu519@mykernel.net>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20191016022501.760-1-cgxu519@mykernel.netSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    57c32ea4
super.c 175 KB