• Lee Jones's avatar
    scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions · e721eb06
    Lee Jones authored
    According to 'include/scsi/scsi_transport_fc.h':
    
     "Attributes are based on HBAAPI V2.0 definitions"
    
    ... so it seems sane to match the 'HBA Attribute Length' to them.
    
    If we don't, the compiler complains that the copied data will be truncated.
    
    Fixes the following W=1 kernel build warning(s):
    
     In file included from include/linux/bitmap.h:9,
     from include/linux/cpumask.h:12,
     from include/linux/smp.h:13,
     from include/linux/percpu.h:7,
     from include/scsi/libfc.h:13,
     from drivers/scsi/libfc/fc_elsct.c:17:
     In function ‘strncpy’,
     inlined from ‘fc_ct_ms_fill.constprop’ at include/scsi/fc_encode.h:263:3:
     include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length  79 [-Wstringop-truncation]
     297 | #define __underlying_strncpy __builtin_strncpy
     | ^
     include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’
     307 | return __underlying_strncpy(p, q, size);
     | ^~~~~~~~~~~~~~~~~~~~
     In function ‘strncpy’,
     inlined from ‘fc_ct_ms_fill.constprop’ at include/scsi/fc_encode.h:275:3:
     include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length 79 [-Wstringop-truncation]
     297 | #define __underlying_strncpy __builtin_strncpy
     | ^
     include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’
     307 | return __underlying_strncpy(p, q, size);
     | ^~~~~~~~~~~~~~~~~~~~
    
    Link: https://lore.kernel.org/r/20200713074645.126138-3-lee.jones@linaro.orgReviewed-by: default avatarHannes Reinecke <hare@suse.de>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    e721eb06
fc_ms.h 4.63 KB