• Johan Hovold's avatar
    dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding · e8e58e29
    Johan Hovold authored
    The current QMP USB PHY bindings are based on the original MSM8996 PCIe
    PHY binding which provided multiple PHYs per IP block and these in turn
    were described by child nodes.
    
    The QMP USB PHY block only provide a single PHY and the remnant child
    node does not really reflect the hardware.
    
    The original MSM8996 binding also ended up describing the individual
    register blocks as belonging to either the wrapper node or the PHY child
    nodes.
    
    This is an unnecessary level of detail which has lead to problems when
    later IP blocks using different register layouts have been forced to fit
    the original mould rather than updating the binding. The bindings are
    arguable also incomplete as they only the describe register blocks used
    by the current Linux drivers (e.g. does not include the per lane PCS
    registers).
    
    Note that PCS_USB region is also not described by the current bindings
    despite being used by the driver and this has led to people increasing
    the size of the PCS region in the devicetree so that it includes PCS_USB
    registers even though other regions like TX and RX may lie in between.
    
    Add a new binding for the QMP USB PHYs found on SC8280XP which further
    bindings can be based on.
    
    Note that this also fixes the SC8280XP "phy_phy" reset name.
    
    Also note that the current binding is simply removed instead of being
    deprecated as it was only recently merged and support for SC8280XP is
    still under development. And, specifically, there is no support in
    mainline for the multiport controller that uses these PHYs.
    Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
    Reviewed-by: default avatarRob Herring <robh@kernel.org>
    Link: https://lore.kernel.org/r/20221028160435.26948-12-johan+linaro@kernel.orgSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
    e8e58e29
qcom,msm8996-qmp-usb3-phy.yaml 8.75 KB