• Omar Sandoval's avatar
    btrfs: fix RAID direct I/O reads with alternate csums · e7a04894
    Omar Sandoval authored
    btrfs_lookup_and_bind_dio_csum() does pointer arithmetic which assumes
    32-bit checksums. If using a larger checksum, this leads to spurious
    failures when a direct I/O read crosses a stripe. This is easy
    to reproduce:
    
      # mkfs.btrfs -f --checksum blake2 -d raid0 /dev/vdc /dev/vdd
      ...
      # mount /dev/vdc /mnt
      # cd /mnt
      # dd if=/dev/urandom of=foo bs=1M count=1 status=none
      # dd if=foo of=/dev/null bs=1M iflag=direct status=none
      dd: error reading 'foo': Input/output error
      # dmesg | tail -1
      [  135.821568] BTRFS warning (device vdc): csum failed root 5 ino 257 off 421888 ...
    
    Fix it by using the actual checksum size.
    
    Fixes: 1e25a2e3 ("btrfs: don't assume ordered sums to be 4 bytes")
    CC: stable@vger.kernel.org # 5.4+
    Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
    Signed-off-by: default avatarOmar Sandoval <osandov@fb.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    e7a04894
inode.c 288 KB