• Willy Tarreau's avatar
    floppy: rename the global "fdc" variable to "current_fdc" · e83995c9
    Willy Tarreau authored
    This is done in order to remove the confusion that arises at some places
    in the code where local variables or arguments shadow the global variable.
    It is already visible that some places are a bit awkward and iterate over
    the global variable, for the sole reason that they used to rely on it being
    named "fdc" in order to get the correct address when using FD_DOR. These
    ones are easy to spot by searching for "for (current_fdc...".
    
    Some more cleanup is definitely possible. For example
    "fdc_state[current_fdc].somefield" is used all over the code and would
    probably be better with "fdc_state->somefield" with fdc_state being set
    when current_fdc is assigned. This would require to pass the pointer to
    the current state instead of the current_fdc to the I/O functions.
    
    Link: https://lore.kernel.org/r/20200301195555.11154-7-w@1wt.eu
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
    Signed-off-by: default avatarDenis Efremov <efremov@linux.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    e83995c9
floppy.c 136 KB