• Michael Ellerman's avatar
    [POWERPC] spufs: Cleanup ELF coredump extra notes logic · e5501492
    Michael Ellerman authored
    To start with, arch_notes_size() etc. is a little too ambiguous a name for
    my liking, so change the function names to be more explicit.
    
    Calling through macros is ugly, especially with hidden parameters, so don't
    do that, call the routines directly.
    
    Use ARCH_HAVE_EXTRA_ELF_NOTES as the only flag, and based on it decide
    whether we want the extern declarations or the empty versions.
    
    Since we have empty routines, actually use them in the coredump code to
    save a few #ifdefs.
    
    We want to change the handling of foffset so that the write routine updates
    foffset as it goes, instead of using file->f_pos (so that writing to a pipe
    works).  So pass foffset to the write routine, and for now just set it to
    file->f_pos at the end of writing.
    
    It should also be possible for the write routine to fail, so change it to
    return int and treat a non-zero return as failure.
    Signed-off-by: default avatarMichael Ellerman <michael@ellerman.id.au>
    Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
    Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
    e5501492
binfmt_elf.c 47.5 KB