• Kefeng Wang's avatar
    mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() · e8a796fa
    Kefeng Wang authored
    Commit b15c8726 ("hwpoison, memory_hotplug: allow hwpoisoned pages to
    be offlined") don't handle the hugetlb pages, the endless loop still occur
    if offline a hwpoison hugetlb page, luckly, after the commit e591ef7d
    ("mm, hwpoison,hugetlb,memory_hotplug: hotremove memory section with
    hwpoisoned hugepage"), the HPageMigratable of hugetlb page will be
    cleared, and the hwpoison hugetlb page will be skipped in
    scan_movable_pages(), so the endless loop issue is fixed.
    
    However if the HPageMigratable() check passed(without reference and lock),
    the hugetlb page may be hwpoisoned, it won't cause issue since the
    hwpoisoned page will be handled correctly in the next movable pages scan
    loop, and it will be isolated in do_migrate_range() but fails to migrate. 
    In order to avoid the unnecessary isolation and unify all hwpoisoned page
    handling, let's unconditionally check hwpoison firstly, and if it is a
    hwpoisoned hugetlb page, try to unmap it as the catch all safety net like
    normal page does.
    
    Link: https://lkml.kernel.org/r/20240827114728.3212578-4-wangkefeng.wang@huawei.comSigned-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
    Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
    Reviewed-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
    Cc: Dan Carpenter <dan.carpenter@linaro.org>
    Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
    Cc: Oscar Salvador <osalvador@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    e8a796fa
memory_hotplug.c 68.1 KB