• Arnd Bergmann's avatar
    ubifs: replay: Fix high stack usage · eb66eff6
    Arnd Bergmann authored
    Having two shash descriptors on the stack cause a very significant kernel
    stack usage that can cross the warning threshold:
    
    fs/ubifs/replay.c: In function 'authenticate_sleb':
    fs/ubifs/replay.c:633:1: error: the frame size of 1144 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
    
    Normally, gcc optimizes the out, but with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING,
    it does not. Splitting the two stack allocations into separate functions
    means that they will use the same memory again. In normal configurations
    (optimizing for size or performance), those should get inlined and we get
    the same behavior as before.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    eb66eff6
replay.c 33.5 KB