• Nathan Chancellor's avatar
    mailbox: imx: Avoid using val uninitialized in imx_mu_isr() · e80a7e7e
    Nathan Chancellor authored
    Clang warns:
    
    drivers/mailbox/imx-mailbox.c:284:2: warning: variable 'val' is used
    uninitialized whenever switch default is taken
    [-Wsometimes-uninitialized]
            default:
            ^~~~~~~
    drivers/mailbox/imx-mailbox.c:288:7: note: uninitialized use occurs here
            if (!val)
                 ^~~
    drivers/mailbox/imx-mailbox.c:263:9: note: initialize the variable 'val'
    to silence this warning
            u32 val, ctrl;
                   ^
                    = 0
    1 warning generated.
    
    Prior to commit 91c8c1fbe498 ("mailbox: imx: add xSR/xCR register
    array"), val was always initialized in imx_mu_isr() but now, it is not
    initialized in the default case. Return IRQ_NONE like the statement
    below does and add a message that there is an unhandled type for this
    switch statement so that it can be updated.
    
    Fixes: 91c8c1fbe498 ("mailbox: imx: add xSR/xCR register array")
    Link: https://github.com/ClangBuiltLinux/linux/issues/1404Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
    Signed-off-by: default avatarJassi Brar <jaswinder.singh@linaro.org>
    e80a7e7e
imx-mailbox.c 17.6 KB