• Jim Mattson's avatar
    KVM: selftests: Fix nested SVM tests when built with clang · ed290e1c
    Jim Mattson authored
    Though gcc conveniently compiles a simple memset to "rep stos," clang
    prefers to call the libc version of memset. If a test is dynamically
    linked, the libc memset isn't available in L1 (nor is the PLT or the
    GOT, for that matter). Even if the test is statically linked, the libc
    memset may choose to use some CPU features, like AVX, which may not be
    enabled in L1. Note that __builtin_memset doesn't solve the problem,
    because (a) the compiler is free to call memset anyway, and (b)
    __builtin_memset may also choose to use features like AVX, which may
    not be available in L1.
    
    To avoid a myriad of problems, use an explicit "rep stos" to clear the
    VMCB in generic_svm_setup(), which is called both from L0 and L1.
    Reported-by: default avatarRicardo Koller <ricarkol@google.com>
    Signed-off-by: default avatarJim Mattson <jmattson@google.com>
    Fixes: 20ba262f ("selftests: KVM: AMD Nested test infrastructure")
    Message-Id: <20210930003649.4026553-1-jmattson@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    ed290e1c
svm.c 5.18 KB