• Mike Snitzer's avatar
    dm: fix bio splitting and its bio completion order for regular IO · ee1dfad5
    Mike Snitzer authored
    dm_queue_split() is removed because __split_and_process_bio() _must_
    handle splitting bios to ensure proper bio submission and completion
    ordering as a bio is split.
    
    Otherwise, multiple recursive calls to ->submit_bio will cause multiple
    split bios to be allocated from the same ->bio_split mempool at the same
    time. This would result in deadlock in low memory conditions because no
    progress could be made (only one bio is available in ->bio_split
    mempool).
    
    This fix has been verified to still fix the loss of performance, due
    to excess splitting, that commit 120c9257 provided.
    
    Fixes: 120c9257 ("Revert "dm: always call blk_queue_split() in dm_process_bio()"")
    Cc: stable@vger.kernel.org # 5.0+, requires custom backport due to 5.9 changes
    Reported-by: default avatarMing Lei <ming.lei@redhat.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    ee1dfad5
dm.c 74.8 KB