• Akinobu Mita's avatar
    cpu hotplug: intel_cacheinfo: fix cpu hotplug error handling · ef1d7151
    Akinobu Mita authored
    - Fix resource leakage in error case within detect_cache_attributes()
    
    - Don't register hotcpu notifier when cache_add_dev() returns error
    
    - Introduce cache_dev_map cpumask to track whether cache interface for
      CPU is successfully added by cache_add_dev() or not.
    
      cache_add_dev() may fail with out of memory error. In order to
      avoid cache_remove_dev() with that uninitialized cache interface when
      CPU_DEAD event is delivered we need to have the cache_dev_map cpumask.
    
      (We cannot change cache_add_dev() from CPU_ONLINE event handler
      to CPU_UP_PREPARE event handler. Because cache_add_dev() needs
      to do cpuid and store the results with its CPU online.)
    
    [nix.or.die@googlemail.com: fix a section mismatch warning]
    Cc: Ashok Raj <ashok.raj@intel.com>
    Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
    Cc: Gautham R Shenoy <ego@in.ibm.com>
    Cc: Oleg Nesterov <oleg@tv-sign.ru>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Jan Beulich <jbeulich@novell.com>
    Signed-off-by: default avatarGabriel Craciunescu <nix.or.die@googlemail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ef1d7151
intel_cacheinfo.c 21.7 KB