• Huang Ying's avatar
    mm,do_huge_pmd_numa_page: remove unnecessary TLB flushing code · f00230ff
    Huang Ying authored
    Before commit c5b5a3dd ("mm: thp: refactor NUMA fault handling"), the
    TLB flushing is done in do_huge_pmd_numa_page() itself via
    flush_tlb_range().
    
    But after commit c5b5a3dd ("mm: thp: refactor NUMA fault handling"),
    the TLB flushing is done in migrate_pages() as in the following code path
    anyway.
    
    do_huge_pmd_numa_page
      migrate_misplaced_page
        migrate_pages
    
    So now, the TLB flushing code in do_huge_pmd_numa_page() becomes
    unnecessary.  So the code is deleted in this patch to simplify the code.
    This is only code cleanup, there's no visible performance difference.
    
    The mmu_notifier_invalidate_range() in do_huge_pmd_numa_page() is
    deleted too.  Because migrate_pages() takes care of that too when CPU
    TLB is flushed.
    
    Link: https://lkml.kernel.org/r/20210720065529.716031-1-ying.huang@intel.comSigned-off-by: default avatar"Huang, Ying" <ying.huang@intel.com>
    Reviewed-by: default avatarZi Yan <ziy@nvidia.com>
    Reviewed-by: default avatarYang Shi <shy828301@gmail.com>
    Cc: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
    Cc: Heiko Carstens <hca@linux.ibm.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: Vasily Gorbik <gor@linux.ibm.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f00230ff
huge_memory.c 85.5 KB