• Adrian Hunter's avatar
    perf parse: Allow config terms with breakpoints · f0617f52
    Adrian Hunter authored
    Add config terms to the parsing of breakpoint events. Extend "Test event
    parsing" to also cover using a confg term.
    
    This makes breakpoint events consistent with other events which already
    support config terms.
    
    Example:
    
      $ cat dr_test.c
      #include <unistd.h>
      #include <stdio.h>
    
      void func0(void)
      {
      }
    
      int main()
      {
              printf("func0 %p\n", &func0);
              while (1) {
                      func0();
                      usleep(100000);
              }
              return 0;
      }
      $ gcc -g -O0 -o dr_test dr_test.c
      $ ./dr_test &
      [2] 19646
      func0 0x55feb98dd169
      $ perf record -e mem:0x55feb98dd169:x/name=breakpoint/ -p 19646 -- sleep 0.5
      [ perf record: Woken up 1 times to write data ]
      [ perf record: Captured and wrote 0.017 MB perf.data (5 samples) ]
      $ perf script
          dr_test 19646  5632.956628:          1 breakpoint:      55feb98dd169 func0+0x0 (/home/ahunter/git/work/dr_test)
          dr_test 19646  5633.056866:          1 breakpoint:      55feb98dd169 func0+0x0 (/home/ahunter/git/work/dr_test)
          dr_test 19646  5633.157084:          1 breakpoint:      55feb98dd169 func0+0x0 (/home/ahunter/git/work/dr_test)
          dr_test 19646  5633.257309:          1 breakpoint:      55feb98dd169 func0+0x0 (/home/ahunter/git/work/dr_test)
          dr_test 19646  5633.357532:          1 breakpoint:      55feb98dd169 func0+0x0 (/home/ahunter/git/work/dr_test)
      $ sudo perf test "Test event parsing"
        6: Parse event definition strings                                  :
        6.1: Test event parsing                                            : Ok
      $ sudo perf test -v "Test event parsing" |& grep mem
      running test 8 'mem:0'
      running test 9 'mem:0:x'
      running test 10 'mem:0:r'
      running test 11 'mem:0:w'
      running test 19 'mem:0:u'
      running test 20 'mem:0:x:k'
      running test 21 'mem:0:r:hp'
      running test 22 'mem:0:w:up'
      running test 26 'mem:0:rw'
      running test 27 'mem:0:rw:kp'
      running test 42 'mem:0/1'
      running test 43 'mem:0/2:w'
      running test 44 'mem:0/4:rw:u'
      running test 58 'mem:0/name=breakpoint/'
      running test 59 'mem:0:x/name=breakpoint/'
      running test 60 'mem:0:r/name=breakpoint/'
      running test 61 'mem:0:w/name=breakpoint/'
      running test 62 'mem:0/name=breakpoint/u'
      running test 63 'mem:0:x/name=breakpoint/k'
      running test 64 'mem:0:r/name=breakpoint/hp'
      running test 65 'mem:0:w/name=breakpoint/up'
      running test 66 'mem:0:rw/name=breakpoint/'
      running test 67 'mem:0:rw/name=breakpoint/kp'
      running test 68 'mem:0/1/name=breakpoint/'
      running test 69 'mem:0/2:w/name=breakpoint/'
      running test 70 'mem:0/4:rw/name=breakpoint/u'
      running test 71 'mem:0/1/name=breakpoint1/,mem:0/4:rw/name=breakpoint2/'
    
    Committer notes:
    
    Folded follow up patch (see 2nd link below) to address warnings about
    unused tokens:
    
    perf tools: Suppress bison unused value warnings
    
    Patch "perf tools: Allow config terms with breakpoints" introduced parse
    tokens for colons and slashes within breakpoint parsing to prevent mix
    up with colons and slashes related to config terms.
    
    The token values are not needed but introduce bison "unused value"
    warnings.
    
    Suppress those warnings.
    
    Committer testing:
    
      # cat ~acme/c/mem_breakpoint.c
      #include <stdio.h>
      #include <unistd.h>
    
      void func1(void) { }
      void func2(void) { }
      void func3(void) { }
      void func4(void) { }
      void func5(void) { }
    
      int main()
      {
      	printf("func1 %p\n", &func1);
      	printf("func2 %p\n", &func2);
      	printf("func3 %p\n", &func3);
      	printf("func4 %p\n", &func4);
      	printf("func5 %p\n", &func5);
      	while (1) {
      		func1(); func2(); func3(); func4(); func5();
      		usleep(100000);
      	}
      	return 0;
      }
    
      # ~acme/c/mem_breakpoint &
      [1] 3186153
      func1 0x401136
      func2 0x40113d
      func3 0x401144
      func4 0x40114b
      func5 0x401152
      #
    
    Trying to watch the first 4 functions for eXecutable access:
    
      # perf record -e mem:0x401136:x/name=breakpoint1/,mem:0x40113d:x/name=breakpoint2/,mem:0x401144:x/name=breakpoint3/,mem:0x40114b:x/name=breakpoint4/  -p 3186153 -- sleep 0.5
      [ perf record: Woken up 1 times to write data ]
      [ perf record: Captured and wrote 0.026 MB perf.data (20 samples) ]
      [root@five ~]# perf script
        mem_breakpoint 3186153 131612.864793:  1 breakpoint1:  401136 func1+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.864795:  1 breakpoint2:  40113d func2+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.864796:  1 breakpoint3:  401144 func3+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.864797:  1 breakpoint4:  40114b func4+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.964868:  1 breakpoint1:  401136 func1+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.964870:  1 breakpoint2:  40113d func2+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.964871:  1 breakpoint3:  401144 func3+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131612.964872:  1 breakpoint4:  40114b func4+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.064945:  1 breakpoint1:  401136 func1+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.064948:  1 breakpoint2:  40113d func2+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.064948:  1 breakpoint3:  401144 func3+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.064949:  1 breakpoint4:  40114b func4+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.165024:  1 breakpoint1:  401136 func1+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.165026:  1 breakpoint2:  40113d func2+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.165027:  1 breakpoint3:  401144 func3+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.165028:  1 breakpoint4:  40114b func4+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.265103:  1 breakpoint1:  401136 func1+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.265105:  1 breakpoint2:  40113d func2+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.265106:  1 breakpoint3:  401144 func3+0x0 (/var/home/acme/c/mem_breakpoint)
        mem_breakpoint 3186153 131613.265107:  1 breakpoint4:  40114b func4+0x0 (/var/home/acme/c/mem_breakpoint)
      #
    
    Then all the 5 functions:
    
      # perf record -e mem:0x401136:x/name=breakpoint1/,mem:0x40113d:x/name=breakpoint2/,mem:0x401144:x/name=breakpoint3/,mem:0x40114b:x/name=breakpoint4/,mem:0x401152:x/name=breakpoint5/ -p 3186153 -- sleep 0.5
      Error:
      The sys_perf_event_open() syscall returned with 28 (No space left on device) for event (breakpoint5).
      /bin/dmesg | grep -i perf may provide additional information.
    
      # grep -m1 'model name' /proc/cpuinfo
      model name	: AMD Ryzen 9 5950X 16-Core Processor
      #
    Reviewed-by: default avatarIan Rogers <irogers@google.com>
    Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: https://lore.kernel.org/r/20230525082902.25332-2-adrian.hunter@intel.com
    Link: https://lore.kernel.org/r/f7228dc9-fe18-a8e3-7d3f-52922e0e1113@intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    f0617f52
parse-events.c 70.7 KB