• Thomas Pedersen's avatar
    mac80211: fix smatch lock errors in mesh · f06c7885
    Thomas Pedersen authored
    smatch was complaining:
    
    CHECK   net/mac80211/mesh_pathtbl.c
    net/mac80211/mesh_pathtbl.c:562 mesh_path_add() error: double lock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:580 mesh_path_add() error: double unlock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:589 mesh_path_add() error: double unlock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:691 mpp_path_add() error: double lock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:707 mpp_path_add() error: double unlock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:716 mpp_path_add() error: double unlock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:814 mesh_path_flush_by_nexthop() error:
    double lock 'bottom_half:'
    net/mac80211/mesh_pathtbl.c:819 mesh_path_flush_by_nexthop() error:
    double unlock 'bottom_half:'
    net/mac80211/mesh_pathtbl.c:887 mesh_path_del() error: double lock
    'bottom_half:'
    net/mac80211/mesh_pathtbl.c:901 mesh_path_del() error: double unlock
    'bottom_half:'
    
    So don't lock / unlock with _bh() while bottom halves are already
    disabled.
    Reported-by: default avatarJohannes Berg <johannes@sipsolutions.net>
    Signed-off-by: default avatarThomas Pedersen <thomas@cozybit.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    f06c7885
mesh_pathtbl.c 29.3 KB