Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • scripts
  • package
  • gen-diff-patch
Find file BlameHistoryPermalink
  • Masahiro Yamada's avatar
    kbuild: give up untracked files for source package builds · aa7d233f
    Masahiro Yamada authored Apr 10, 2023
    When the source tree is dirty and contains untracked files, package
    builds may fail, for example, when a broken symlink exists, a file
    path contains whitespaces, etc.
    
    Since commit 05e96e96 ("kbuild: use git-archive for source package
    creation"), the source tarball only contains committed files because
    it is created by 'git archive'. scripts/package/gen-diff-patch tries
    to address the diff from HEAD, but including untracked files by the
    hand-crafted script introduces more complexity. I wrote a patch [1] to
    make it work in most cases, but still wonder if this is what we should
    aim for.
    
    To simplify the code, this patch just gives up untracked files. Going
    forward, it is your responsibility to do 'git add' for what you want in
    the source package. The script shows a warning just in case you forgot
    to do so. It should be checked only when building source packages.
    
    [1]: https://lore.kernel.org/all/CAK7LNAShbZ56gSh9PrbLnBDYKnjtTkHMoCXeGrhcxMvqXGq9=g@mail.gmail.com/2-0001-kbuild-make-package-builds-more-robust.patch
    
    Fixes: 05e96e96
    
     ("kbuild: use git-archive for source package creation")
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Reviewed-by: default avatarNicolas Schier <nicolas@fjasle.eu>
    aa7d233f
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7