• Paul Bolle's avatar
    [SCSI] qla2xxx: silence two GCC warnings. · f24b697b
    Paul Bolle authored
    Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
    warnings:
        drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’:
        drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above array bounds [-Warray-bounds]
        drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_register’:
        drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is above array bounds [-Warray-bounds]
    
    It seems that the sequence of a strcpy followed by a strlen confuses GCC
    when it is keeping track of array bounds here. (It is not clear to me
    which array triggers this warning and by how much GCC thinks the
    subscript is above its bounds. Neither is it clear to me why comparable
    code in these two functions doesn't trigger this warning.)
    
    An easy way to silence these warnings is to use preprocessor macros and
    strncpy, as that apparently gives GCC enough information to keep track
    of array bounds.
    Signed-off-by: default avatarPaul Bolle <pebolle@tiscali.nl>
    Signed-off-by: default avatarSaurav Kashyap <saurav.kashyap@qlogic.com>
    Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
    f24b697b
qla_def.h 91.3 KB