• Louis Rilling's avatar
    configfs: Rework configfs_depend_item() locking and make lockdep happy · 420118ca
    Louis Rilling authored
    configfs_depend_item() recursively locks all inodes mutex from configfs root to
    the target item, which makes lockdep unhappy. The purpose of this recursive
    locking is to ensure that the item tree can be safely parsed and that the target
    item, if found, is not about to leave.
    
    This patch reworks configfs_depend_item() locking using configfs_dirent_lock.
    Since configfs_dirent_lock protects all changes to the configfs_dirent tree, and
    protects tagging of items to be removed, this lock can be used instead of the
    inodes mutex lock chain.
    This needs that the check for dependents be done atomically with
    CONFIGFS_USET_DROPPING tagging.
    
    Now lockdep looks happy with configfs.
    
    [ Lifted the setting of s_type into configfs_new_dirent() to satisfy the
      atomic setting of CONFIGFS_USET_CREATING  -- Joel ]
    Signed-off-by: default avatarLouis Rilling <louis.rilling@kerlabs.com>
    Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
    420118ca
dir.c 43.6 KB