• Vaibhav Jain's avatar
    powerpc/papr_scm: Reduce error severity if nvdimm stats inaccessible · f3f6d184
    Vaibhav Jain authored
    Currently drc_pmem_qeury_stats() generates a dev_err in case
    "Enable Performance Information Collection" feature is disabled from
    HMC or performance stats are not available for an nvdimm. The error is
    of the form below:
    
    papr_scm ibm,persistent-memory:ibm,pmemory@44104001: Failed to query
    	 performance stats, Err:-10
    
    This error message confuses users as it implies a possible problem
    with the nvdimm even though its due to a disabled/unavailable
    feature. We fix this by explicitly handling the H_AUTHORITY and
    H_UNSUPPORTED errors from the H_SCM_PERFORMANCE_STATS hcall.
    
    In case of H_AUTHORITY error an info message is logged instead of an
    error, saying that "Permission denied while accessing performance
    stats" and an EPERM error is returned back.
    
    In case of H_UNSUPPORTED error we return a EOPNOTSUPP error back from
    drc_pmem_query_stats() indicating that performance stats-query
    operation is not supported on this nvdimm.
    
    Fixes: 2d02bf83 ("powerpc/papr_scm: Fetch nvdimm performance stats from PHYP")
    Signed-off-by: default avatarVaibhav Jain <vaibhav@linux.ibm.com>
    Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20210508043642.114076-1-vaibhav@linux.ibm.com
    f3f6d184
papr_scm.c 32.6 KB