• Dave Jiang's avatar
    dmaengine: ioatdma: fix uninitialized array usage · 2eab9b1a
    Dave Jiang authored
    Static analysis showed that unitialized array is being used for compare.
    At line 850 when a dma_mapping_error() occurs, it jumps to dma_unmap. At
    this point, dma_srcs has not been initialized. However, the code after
    dma_unmap label checks dma_srcs for a comparison and thus is comparing
    to random garbage in the array. Given that when dest_dma is being mapped
    this is the first instance of mapping DMA memory and failed, there is
    really nothing to be cleaned up and thus should jump to free_resources
    label instead.
    Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
    Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
    2eab9b1a
init.c 37.7 KB