• Arnd Bergmann's avatar
    kexec: select CRYPTO from KEXEC_FILE instead of depending on it · e63bde3d
    Arnd Bergmann authored
    All other users of crypto code use 'select' instead of 'depends on', so do
    the same thing with KEXEC_FILE for consistency.
    
    In practice this makes very little difference as kernels with kexec
    support are very likely to also include some other feature that already
    selects both crypto and crypto_sha256, but being consistent here helps for
    usability as well as to avoid potential circular dependencies.
    
    This reverts the dependency back to what it was originally before commit
    74ca317c ("kexec: create a new config option CONFIG_KEXEC_FILE for
    new syscall"), which changed changed it with the comment "This should be
    safer as "select" is not recursive", but that appears to have been done in
    error, as "select" is indeed recursive, and there are no other
    dependencies that prevent CRYPTO_SHA256 from being selected here.
    
    Link: https://lkml.kernel.org/r/20231023110308.1202042-2-arnd@kernel.org
    Fixes: 74ca317c ("kexec: create a new config option CONFIG_KEXEC_FILE for new syscall")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarEric DeVolder <eric_devolder@yahoo.com>
    Tested-by: default avatarEric DeVolder <eric_devolder@yahoo.com>
    Acked-by: default avatarBaoquan He <bhe@redhat.com>
    Cc: Herbert Xu <herbert@gondor.apana.org.au>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Albert Ou <aou@eecs.berkeley.edu>
    Cc: Alexander Gordeev <agordeev@linux.ibm.com>
    Cc: Ard Biesheuvel <ardb@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
    Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
    Cc: Conor Dooley <conor@kernel.org>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Heiko Carstens <hca@linux.ibm.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Nicholas Piggin <npiggin@gmail.com>
    Cc: Palmer Dabbelt <palmer@dabbelt.com>
    Cc: Paul Walmsley <paul.walmsley@sifive.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sven Schnelle <svens@linux.ibm.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vasily Gorbik <gor@linux.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    e63bde3d
Kconfig.kexec 5.1 KB