• Marek Vasut's avatar
    drm/bridge: tc358767: Enable FRMSYNC timing generator · d9ca4b76
    Marek Vasut authored
    TC9595 datasheet Video Path0 Control (VPCTRL0) Register bit FRMSYNC description
    says "This bit should be disabled only in video mode transmission where Host
    transmits video timing together with video data and where pixel clock source
    is from DSI clock." . This driver always sources pixel clock from external xtal,
    therefore the FRMSYNC bit must always be enabled, enable it.
    
    This fixes an actual issue with DSI-to-DPI mode, where the display would
    randomly show subtle pixel flickering, or wobble, or shimmering. This is
    visible on solid gray color, but the degree of the shimmering differs
    between boots, which makes it hard to debug.
    
    There is a caveat to the FRMSYNC and this bridge pixel PLL, which can only
    generate pixel clock with limited accuracy, it may therefore be necessary
    to reduce the HFP to fit into line length of input pixel data, to avoid any
    possible overflows, which make the output video look striped horizontally.
    Signed-off-by: default avatarMarek Vasut <marex@denx.de>
    Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
    Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20240513021607.129111-1-marex@denx.de
    d9ca4b76
tc358767.c 64 KB