• Xuewen Yan's avatar
    cpufreq: schedutil: Update next_freq when cpufreq_limits change · 9e0bc36a
    Xuewen Yan authored
    When cpufreq's policy is 'single', there is a scenario that will
    cause sg_policy's next_freq to be unable to update.
    
    When the CPU's util is always max, the cpufreq will be max,
    and then if we change the policy's scaling_max_freq to be a
    lower freq, indeed, the sg_policy's next_freq need change to
    be the lower freq, however, because the cpu_is_busy, the next_freq
    would keep the max_freq.
    
    For example:
    
    The cpu7 is a single CPU:
    
      unisoc:/sys/devices/system/cpu/cpufreq/policy7 # while true;do done& [1] 4737
      unisoc:/sys/devices/system/cpu/cpufreq/policy7 # taskset -p 80 4737
      pid 4737's current affinity mask: ff
      pid 4737's new affinity mask: 80
      unisoc:/sys/devices/system/cpu/cpufreq/policy7 # cat scaling_max_freq
      2301000
      unisoc:/sys/devices/system/cpu/cpufreq/policy7 # cat scaling_cur_freq
      2301000
      unisoc:/sys/devices/system/cpu/cpufreq/policy7 # echo 2171000 > scaling_max_freq
      unisoc:/sys/devices/system/cpu/cpufreq/policy7 # cat scaling_max_freq
      2171000
    
    At this time, the sg_policy's next_freq would stay at 2301000, which
    is wrong.
    
    To fix this, add a check for the ->need_freq_update flag.
    
    [ mingo: Clarified the changelog. ]
    Co-developed-by: default avatarGuohua Yan <guohua.yan@unisoc.com>
    Signed-off-by: default avatarXuewen Yan <xuewen.yan@unisoc.com>
    Signed-off-by: default avatarGuohua Yan <guohua.yan@unisoc.com>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    Acked-by: default avatar"Rafael J. Wysocki" <rafael@kernel.org>
    Link: https://lore.kernel.org/r/20230719130527.8074-1-xuewen.yan@unisoc.com
    9e0bc36a
cpufreq_schedutil.c 23.6 KB