• Frank Li's avatar
    arm64: dts: imx8-ss-dma: fix spi lpcg indices · f72b544a
    Frank Li authored
    spi0_lpcg: clock-controller@5a400000 {
    	...                                                  Col0   Col1
    	clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>,//   0      1
    		 <&dma_ipg_clk>;                         //   1      4
    	clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
    };
    
    Col1: index, which existing dts try to get.
    Col2: actual index in lpcg driver.
    
    lpspi0: spi@5a000000 {
    	...
    	clocks = <&spi0_lpcg 0>, <&spi0_lpcg 1>;
    			     ^		     ^
    Should be:
    	clocks = <&spi0_lpcg IMX_LPCG_CLK_0>, <&spi0_lpcg IMX_LPCG_CLK_4>;
    };
    
    Arg0 is divided by 4 in lpcg driver. <&spi0_lpcg 0> and <&spi0_lpcg 1> are
    IMX_SC_PM_CLK_PER. Although code can work, code logic is wrong. It should
    use IMX_LPCG_CLK_0 and IMX_LPCG_CLK_4 for lpcg arg0.
    
    Cc: stable@vger.kernel.org
    Fixes: c4098885 ("arm64: dts: imx8dxl: add lpspi support")
    Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
    Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
    f72b544a
imx8-ss-dma.dtsi 16.6 KB