• Arnd Bergmann's avatar
    pinctrl: s32cc: fix !CONFIG_PM_SLEEP build error · f7fc5768
    Arnd Bergmann authored
    The declaration of s32_pinctrl_suspend/s32_pinctrl_resume is hidden
    in an #ifdef, causing a compilation failure when CONFIG_PM_SLEEP is
    disabled:
    
    drivers/pinctrl/nxp/pinctrl-s32g2.c:754:38: error: 's32_pinctrl_suspend' undeclared here (not in a function); did you mean 's32_pinctrl_probe'?
    drivers/pinctrl/nxp/pinctrl-s32g2.c:754:9: note: in expansion of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS'
      754 |         SET_LATE_SYSTEM_SLEEP_PM_OPS(s32_pinctrl_suspend,
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Remove the bogus #ifdef and __maybe_unused annation on the global
    functions, and instead use the proper LATE_SYSTEM_SLEEP_PM_OPS()
    macro to pick set the function pointer.
    
    As the function definition is still in the #ifdef block, this leads
    to the correct code in all configurations.
    
    Fixes: fd84aaa8 ("pinctrl: add NXP S32 SoC family support")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20230310140250.359147-1-arnd@kernel.orgSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    f7fc5768
pinctrl-s32g2.c 23.9 KB