• Hans de Goede's avatar
    firmware: dmi: Move product_sku info to the end of the modalias · f97a2103
    Hans de Goede authored
    Commit e26f023e ("firmware/dmi: Include product_sku info to modalias")
    added a new field to the modalias in the middle of the modalias, breaking
    some existing udev/hwdb matches on the whole modalias without a wildcard
    ('*') in between the pvr and rvn fields.
    
    All modalias matches in e.g. :
    https://github.com/systemd/systemd/blob/main/hwdb.d/60-sensor.hwdb
    deliberately end in ':*' so that new fields can be added at *the end* of
    the modalias, but adding a new field in the middle like this breaks things.
    
    Move the new sku field to the end of the modalias to fix some hwdb
    entries no longer matching.
    
    The new sku field has already been put to use in 2 new hwdb entries:
    
     sensor:modalias:platform:HID-SENSOR-200073:dmi:*svnDell*:sku0A3E:*
      ACCEL_LOCATION=base
    
     sensor:modalias:platform:HID-SENSOR-200073:dmi:*svnDell*:sku0B0B:*
      ACCEL_LOCATION=base
    
    The wildcard use before and after the sku in these matches means that they
    should keep working w...
    f97a2103
dmi-id.c 7.23 KB