• Steven Rostedt's avatar
    tracing: Only process module tracepoints once · c94fbe1d
    Steven Rostedt authored
    The commit:
    
     9f987b3141f086de27832514aad9f50a53f754
     tracing: Include module.h in define_trace.h
    
    only solved half the problem. If the trace/events/module.h header is
    included at the time of define_trace.h (or in ftrace.h within it),
    the module.h TRACE_SYSTEM will override the current TRACE_SYSTEM
    macro.
    
    Since define_trace.h is included when CREATE_TRACE_POINTS is set,
    and the first thing it does is to #undef CREATE_TRACE_POINTS,
    by placing the module.h TRACE_SYSTEM inside a
     #ifdef CREATE_TRACE_POINTS
    we can prevent it from overriding the TRACE_SYSTEM that is
    being processed, and still process the module.h tracepoints
    when the module code defines CREATE_TRACE_POINTS and includes
    the trace/events/module.h header.
    
    As with commit 9f987b3141, this is only an issue if module.h
    is not included before the trace/events/<event>.h file is
    included, which (luckily) has not happened yet.
    Reported-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    c94fbe1d
module.h 2.71 KB