• Gustavo A. R. Silva's avatar
    pinctrl: rza1: constify gpio_chip structure · fa39210d
    Gustavo A. R. Silva authored
    This structure is only used to copy into other structure, so declare
    it as const.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct gpio_chip i@p = { ... };
    
    @ok@
    identifier r.i;
    expression e;
    position p;
    @@
    e = i@p;
    
    @bad@
    position p != {r.p,ok.p};
    identifier r.i;
    struct gpio_chip e;
    @@
    e@i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
     struct gpio_chip i = { ... };
    
    In the following log you can see a significant difference in the code size
    and data segment, hence in the dec segment. This log is the output
    of the size command, before and after the code change:
    
    before:
       text    data     bss     dec     hex filename
      11866    3520     128   15514    3c9a drivers/pinctrl/pinctrl-rza1.o
    
    after:
       text    data     bss     dec     hex filename
      11539    3464     128   15131    3b1b drivers/pinctrl/pinctrl-rza1.o
    Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    fa39210d
pinctrl-rza1.c 33.4 KB