• Mansur Alisha Shaik's avatar
    media: venus: core: handle race condititon for core ops · 9696960f
    Mansur Alisha Shaik authored
    For core ops we are having only write protect but there
    is no read protect, because of this in multithreading
    and concurrency, one CPU core is reading without wait
    which is causing the NULL pointer dereferece crash.
    
    one such scenario is as show below, where in one CPU
    core, core->ops becoming NULL and in another CPU core
    calling core->ops->session_init().
    
    CPU: core-7:
    Call trace:
     hfi_session_init+0x180/0x1dc [venus_core]
     vdec_queue_setup+0x9c/0x364 [venus_dec]
     vb2_core_reqbufs+0x1e4/0x368 [videobuf2_common]
     vb2_reqbufs+0x4c/0x64 [videobuf2_v4l2]
     v4l2_m2m_reqbufs+0x50/0x84 [v4l2_mem2mem]
     v4l2_m2m_ioctl_reqbufs+0x2c/0x38 [v4l2_mem2mem]
     v4l_reqbufs+0x4c/0x5c
    __video_do_ioctl+0x2b0/0x39c
    
    CPU: core-0:
    Call trace:
     venus_shutdown+0x98/0xfc [venus_core]
     venus_sys_error_handler+0x64/0x148 [venus_core]
     process_one_work+0x210/0x3d0
     worker_thread+0x248/0x3f4
     kthread+0x11c/0x12c
    Signed-off-by: default avatarMansur Alisha Shaik <mansur@codeaurora.org>
    Signed-off-by: default avatarStanimir Varbanov <stanimir.varbanov@linaro.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    9696960f
hfi.c 9.82 KB