• Eric Dumazet's avatar
    net/802/mrp: fix lockdep splat · faff57a9
    Eric Dumazet authored
    commit fb745e9a ("net/802/mrp: fix possible race condition when
    calling mrp_pdu_queue()") introduced a lockdep splat.
    
    [   19.735147] =================================
    [   19.735235] [ INFO: inconsistent lock state ]
    [   19.735324] 3.9.2-build-0063 #4 Not tainted
    [   19.735412] ---------------------------------
    [   19.735500] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage.
    [   19.735592] rmmod/1840 [HC0[0]:SC0[0]:HE1:SE1] takes:
    [   19.735682]  (&(&app->lock)->rlock#2){+.?...}, at: [<f862bb5b>]
    mrp_uninit_applicant+0x69/0xba [mrp]
    
    app->lock is normally taken under softirq context, so disable BH to
    avoid the splat.
    Reported-by: default avatarDenys Fedoryshchenko <denys@visp.net.lb>
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: David Ward <david.ward@ll.mit.edu>
    Cc: Cong Wang <amwang@redhat.com>
    Tested-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    faff57a9
mrp.c 24 KB