• Ming Lei's avatar
    blk-mq: add new API of blk_mq_hctx_set_fq_lock_class · fb01a293
    Ming Lei authored
    flush_end_io() may be called recursively from some driver, such as
    nvme-loop, so lockdep may complain 'possible recursive locking'.
    Commit b3c6a599("block: Fix a lockdep complaint triggered by
    request queue flushing") tried to address this issue by assigning
    dynamically allocated per-flush-queue lock class. This solution
    adds synchronize_rcu() for each hctx's release handler, and causes
    horrible SCSI MQ probe delay(more than half an hour on megaraid sas).
    
    Add new API of blk_mq_hctx_set_fq_lock_class() for these drivers, so
    we just need to use driver specific lock class for avoiding the
    lockdep warning of 'possible recursive locking'.
    Tested-by: default avatarKashyap Desai <kashyap.desai@broadcom.com>
    Reported-by: default avatarQian Cai <cai@redhat.com>
    Cc: Sumit Saxena <sumit.saxena@broadcom.com>
    Cc: John Garry <john.garry@huawei.com>
    Cc: Kashyap Desai <kashyap.desai@broadcom.com>
    Cc: Bart Van Assche <bvanassche@acm.org>
    Cc: Hannes Reinecke <hare@suse.de>
    Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
    Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    fb01a293
blk-flush.c 15.1 KB