• Ariel Levkovich's avatar
    net/sched: act_ct: Fix ct template allocation for zone 0 · fb91702b
    Ariel Levkovich authored
    Fix current behavior of skipping template allocation in case the
    ct action is in zone 0.
    
    Skipping the allocation may cause the datapath ct code to ignore the
    entire ct action with all its attributes (commit, nat) in case the ct
    action in zone 0 was preceded by a ct clear action.
    
    The ct clear action sets the ct_state to untracked and resets the
    skb->_nfct pointer. Under these conditions and without an allocated
    ct template, the skb->_nfct pointer will remain NULL which will
    cause the tc ct action handler to exit without handling commit and nat
    actions, if such exist.
    
    For example, the following rule in OVS dp:
    recirc_id(0x2),ct_state(+new-est-rel-rpl+trk),ct_label(0/0x1), \
    in_port(eth0),actions:ct_clear,ct(commit,nat(src=10.11.0.12)), \
    recirc(0x37a)
    
    Will result in act_ct skipping the commit and nat actions in zone 0.
    
    The change removes the skipping of template allocation for zone 0 and
    treats it the same as any other zone.
    
    Fixes: b57dc7c1 ("net/sched: Introduce action ct")
    Signed-off-by: default avatarAriel Levkovich <lariel@nvidia.com>
    Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    Link: https://lore.kernel.org/r/20210526170110.54864-1-lariel@nvidia.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    fb91702b
act_ct.c 38 KB