• Enrico Bravi's avatar
    ima: fix wrong zero-assignment during securityfs dentry remove · fbf06cee
    Enrico Bravi authored
    In case of error during ima_fs_init() all the dentry already created
    are removed. {ascii, binary}_securityfs_measurement_lists are freed
    calling for each array the remove_securityfs_measurement_lists(). This
    function, at the end, assigns to zero the securityfs_measurement_list_count.
    This causes during the second call of remove_securityfs_measurement_lists()
    to leave the dentry of the array pending, not removing them correctly,
    because the securityfs_measurement_list_count is already zero.
    
    Move the securityfs_measurement_list_count = 0 after the two
    remove_securityfs_measurement_lists() calls to correctly remove all the
    dentry already allocated.
    
    Fixes: 9fa8e762 ("ima: add crypto agility support for template-hash algorithm")
    Signed-off-by: default avatarEnrico Bravi <enrico.bravi@polito.it>
    Reviewed-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
    Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
    fbf06cee
ima_fs.c 15.4 KB