• David Hildenbrand's avatar
    virtio-mem: add memory via add_memory_driver_managed() · b3562c60
    David Hildenbrand authored
    Virtio-mem managed memory is always detected and added by the virtio-mem
    driver, never using something like the firmware-provided memory map.
    This is the case after an ordinary system reboot, and has to be guaranteed
    after kexec. Especially, virtio-mem added memory resources can contain
    inaccessible parts ("unblocked memory blocks"), blindly forwarding them
    to a kexec kernel is dangerous, as unplugged memory will get accessed
    (esp. written).
    
    Let's use the new way of adding special driver-managed memory introduced
    in commit 7b7b2721 ("mm/memory_hotplug: introduce
    add_memory_driver_managed()").
    
    This will result in no entries in /sys/firmware/memmap ("raw firmware-
    provided memory map"), the memory resource will be flagged
    IORESOURCE_MEM_DRIVER_MANAGED (esp., kexec_file_load() will not place
    kexec images on this memory), and it is exposed as "System RAM
    (virtio_mem)" in /proc/iomem, so esp. kexec-tools can properly handle it.
    
    Example /proc/iomem before this change:
      [...]
      140000000-333ffffff : virtio0
        140000000-147ffffff : System RAM
      334000000-533ffffff : virtio1
        338000000-33fffffff : System RAM
        340000000-347ffffff : System RAM
        348000000-34fffffff : System RAM
      [...]
    
    Example /proc/iomem after this change:
      [...]
      140000000-333ffffff : virtio0
        140000000-147ffffff : System RAM (virtio_mem)
      334000000-533ffffff : virtio1
        338000000-33fffffff : System RAM (virtio_mem)
        340000000-347ffffff : System RAM (virtio_mem)
        348000000-34fffffff : System RAM (virtio_mem)
      [...]
    
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
    Cc: teawater <teawaterz@linux.alibaba.com>
    Fixes: 5f1f79bb ("virtio-mem: Paravirtualized memory hotplug")
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Link: https://lore.kernel.org/r/20200611093518.5737-1-david@redhat.comSigned-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarPankaj Gupta <pankaj.gupta.linux@gmail.com>
    b3562c60
virtio_mem.c 53.1 KB