• Chen Gang's avatar
    net: irda: using kzalloc() instead of kmalloc() to avoid strncpy() issue. · ff0102ee
    Chen Gang authored
    'discovery->data.info' length is 22, NICKNAME_MAX_LEN is 21, so the
    strncpy() will always left the last byte of 'discovery->data.info'
    uninitialized.
    
    When 'text' length is longer than 21 (NICKNAME_MAX_LEN), if still left
    the last byte of 'discovery->data.info' uninitialized, the next
    strlen() will cause issue.
    
    Also 'discovery->data' is 'struct irda_device_info' which defined in
    "include/uapi/...", it may copy to user mode, so need whole initialized.
    
    All together, need use kzalloc() instead of kmalloc() to initialize all
    members firstly.
    Signed-off-by: default avatarChen Gang <gang.chen@asianux.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ff0102ee
irlap_frame.c 35.9 KB