• Kuniyuki Iwashima's avatar
    phonet: Handle error of rtnl_register_module(). · b5e837c8
    Kuniyuki Iwashima authored
    Before commit addf9b90 ("net: rtnetlink: use rcu to free rtnl
    message handlers"), once the first rtnl_register_module() allocated
    rtnl_msg_handlers[PF_PHONET], the following calls never failed.
    
    However, after the commit, rtnl_register_module() could fail silently
    to allocate rtnl_msg_handlers[PF_PHONET][msgtype] and requires error
    handling for each call.
    
    Handling the error allows users to view a module as an all-or-nothing
    thing in terms of the rtnetlink functionality.  This prevents syzkaller
    from reporting spurious errors from its tests, where OOM often occurs
    and module is automatically loaded.
    
    Let's use rtnl_register_many() to handle the errors easily.
    
    Fixes: addf9b90 ("net: rtnetlink: use rcu to free rtnl message handlers")
    Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
    Acked-by: default avatarRémi Denis-Courmont <courmisch@gmail.com>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    b5e837c8
pn_netlink.c 7.04 KB