• Maciej S. Szmigiero's avatar
    hp-wmi: Remove GPS rfkill support via pre-2009 interface · fffcad87
    Maciej S. Szmigiero authored
    GPS rfkill support via pre-2009 WMI interface uses hp_wmi_get_sw_state()
    and hp_wmi_get_hw_state() to query its current hard and soft block state,
    respectively.
    
    In hp_wmi_get_sw_state() a mask is calculated which bit should be checked
    in an int value returned by firmware to get current block state: 0x200 <<
    (r * 8) which with r being 3 for GPS results in overflow and mask of zero.
    The same goes for hp_wmi_get_hw_state().
    
    This effectively means that GPS rfkill on this WMI interface is considered
    always both hard and soft blocked.
    
    Unfortunately, later when rfkill subsystem calls hp_wmi_set_block() to sync
    this block to hardware firmware at least on my old nc6400 gets confused and
    sets both hard and soft blocks on WiFi and BT.
    
    This happens for example on hp-wmi module load.
    
    Since due to overflow described above it is dubious that this ever worked
    correctly and HP laptops with modems having GPS support seem to all have
    been released well past year 2009 let's just remove GPS rfkill support via
    pre-2009 WMI interface.
    Signed-off-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
    Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
    fffcad87
hp-wmi.c 24.8 KB