Commit 021212f5 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

serial: meson: remove redundant initialization of variable id

The variable id being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed. Since id is just being used in a for-loop
inside a local scope, move the declaration of id to that scope.
Reviewed-by: default avatarKevin Hilman <khilman@baylibre.com>
Reviewed-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210426101106.9122-1-colin.king@canonical.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5b08386
...@@ -716,12 +716,13 @@ static int meson_uart_probe(struct platform_device *pdev) ...@@ -716,12 +716,13 @@ static int meson_uart_probe(struct platform_device *pdev)
struct resource *res_mem, *res_irq; struct resource *res_mem, *res_irq;
struct uart_port *port; struct uart_port *port;
int ret = 0; int ret = 0;
int id = -1;
if (pdev->dev.of_node) if (pdev->dev.of_node)
pdev->id = of_alias_get_id(pdev->dev.of_node, "serial"); pdev->id = of_alias_get_id(pdev->dev.of_node, "serial");
if (pdev->id < 0) { if (pdev->id < 0) {
int id;
for (id = AML_UART_PORT_OFFSET; id < AML_UART_PORT_NUM; id++) { for (id = AML_UART_PORT_OFFSET; id < AML_UART_PORT_NUM; id++) {
if (!meson_ports[id]) { if (!meson_ports[id]) {
pdev->id = id; pdev->id = id;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment