Commit 02730029 authored by Julia Lawall's avatar Julia Lawall Committed by John W. Linville

drivers/net/wireless/libertas_tf: Use kmemdup

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 80caf601
...@@ -538,7 +538,8 @@ static void if_usb_receive_fwload(struct urb *urb) ...@@ -538,7 +538,8 @@ static void if_usb_receive_fwload(struct urb *urb)
return; return;
} }
syncfwheader = kmalloc(sizeof(struct fwsyncheader), GFP_ATOMIC); syncfwheader = kmemdup(skb->data, sizeof(struct fwsyncheader),
GFP_ATOMIC);
if (!syncfwheader) { if (!syncfwheader) {
lbtf_deb_usbd(&cardp->udev->dev, "Failure to allocate syncfwheader\n"); lbtf_deb_usbd(&cardp->udev->dev, "Failure to allocate syncfwheader\n");
kfree_skb(skb); kfree_skb(skb);
...@@ -546,8 +547,6 @@ static void if_usb_receive_fwload(struct urb *urb) ...@@ -546,8 +547,6 @@ static void if_usb_receive_fwload(struct urb *urb)
return; return;
} }
memcpy(syncfwheader, skb->data, sizeof(struct fwsyncheader));
if (!syncfwheader->cmd) { if (!syncfwheader->cmd) {
lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk with correct CRC\n"); lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk with correct CRC\n");
lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk seqnum = %d\n", lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk seqnum = %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment