Commit 02c0fc1b authored by WANG Cong's avatar WANG Cong Committed by David S. Miller

net_sched: fix unused variables in __gnet_stats_copy_basic_cpu()

Probably not a big deal, but we'd better just use the
one we get in retry loop.

Fixes: commit 22e0f8b9 ("net: sched: make bstats per cpu and estimator RCU safe")
Reported-by: default avatarJoe Perches <joe@perches.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7c5df8fa
...@@ -106,8 +106,8 @@ __gnet_stats_copy_basic_cpu(struct gnet_stats_basic_packed *bstats, ...@@ -106,8 +106,8 @@ __gnet_stats_copy_basic_cpu(struct gnet_stats_basic_packed *bstats,
for_each_possible_cpu(i) { for_each_possible_cpu(i) {
struct gnet_stats_basic_cpu *bcpu = per_cpu_ptr(cpu, i); struct gnet_stats_basic_cpu *bcpu = per_cpu_ptr(cpu, i);
unsigned int start; unsigned int start;
__u64 bytes; u64 bytes;
__u32 packets; u32 packets;
do { do {
start = u64_stats_fetch_begin_irq(&bcpu->syncp); start = u64_stats_fetch_begin_irq(&bcpu->syncp);
...@@ -115,8 +115,8 @@ __gnet_stats_copy_basic_cpu(struct gnet_stats_basic_packed *bstats, ...@@ -115,8 +115,8 @@ __gnet_stats_copy_basic_cpu(struct gnet_stats_basic_packed *bstats,
packets = bcpu->bstats.packets; packets = bcpu->bstats.packets;
} while (u64_stats_fetch_retry_irq(&bcpu->syncp, start)); } while (u64_stats_fetch_retry_irq(&bcpu->syncp, start));
bstats->bytes += bcpu->bstats.bytes; bstats->bytes += bytes;
bstats->packets += bcpu->bstats.packets; bstats->packets += packets;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment