Commit 04b5f1be authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Alexandre Belloni

i3c: dw: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230318233311.265186-3-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 0f74f8b6
......@@ -1182,7 +1182,7 @@ static int dw_i3c_probe(struct platform_device *pdev)
return ret;
}
static int dw_i3c_remove(struct platform_device *pdev)
static void dw_i3c_remove(struct platform_device *pdev)
{
struct dw_i3c_master *master = platform_get_drvdata(pdev);
......@@ -1191,8 +1191,6 @@ static int dw_i3c_remove(struct platform_device *pdev)
reset_control_assert(master->core_rst);
clk_disable_unprepare(master->core_clk);
return 0;
}
static const struct of_device_id dw_i3c_master_of_match[] = {
......@@ -1203,7 +1201,7 @@ MODULE_DEVICE_TABLE(of, dw_i3c_master_of_match);
static struct platform_driver dw_i3c_driver = {
.probe = dw_i3c_probe,
.remove = dw_i3c_remove,
.remove_new = dw_i3c_remove,
.driver = {
.name = "dw-i3c-master",
.of_match_table = dw_i3c_master_of_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment