Commit 04bd6411 authored by Nícolas F. R. A. Prado's avatar Nícolas F. R. A. Prado Committed by AngeloGioacchino Del Regno

arm64: dts: mt8183: Move CrosEC base detection node to kukui-based DTs

The cbas node is used to describe base detection functionality in the
ChromeOS EC, which is used for units that have a detachable keyboard and
thus rely on this functionality to switch between tablet and laptop
mode.

Despite the original commit having added the cbas node to the
mt8183-kukui.dtsi, not all machines that include it are detachables. In
fact all machines that include from mt8183-kukui-jacuzzi.dtsi are either
clamshells (ie normal laptops) or convertibles, meaning the keyboard can
be flipped but not detached. The detection for the keyboard getting
flipped is handled by the driver bound to the keyboard-controller node
in the EC.

Move the base detection node from the base kukui dtsi to the dtsis where
all machines are detachables, and thus actually make use of the node.

Fixes: 4fa8492d ("arm64: dts: mt8183: add cbas node under cros_ec")
Signed-off-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240116-mt8183-kukui-cbas-remove-v3-1-055e21406e86@collabora.comSigned-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 6613476e
...@@ -360,6 +360,10 @@ pen_eject { ...@@ -360,6 +360,10 @@ pen_eject {
}; };
&cros_ec { &cros_ec {
cbas {
compatible = "google,cros-cbas";
};
keyboard-controller { keyboard-controller {
compatible = "google,cros-ec-keyb-switches"; compatible = "google,cros-ec-keyb-switches";
}; };
......
...@@ -339,6 +339,10 @@ touch_pin_reset: pin_reset { ...@@ -339,6 +339,10 @@ touch_pin_reset: pin_reset {
}; };
&cros_ec { &cros_ec {
cbas {
compatible = "google,cros-cbas";
};
keyboard-controller { keyboard-controller {
compatible = "google,cros-ec-keyb-switches"; compatible = "google,cros-ec-keyb-switches";
}; };
......
...@@ -343,6 +343,10 @@ rst_pin { ...@@ -343,6 +343,10 @@ rst_pin {
}; };
&cros_ec { &cros_ec {
cbas {
compatible = "google,cros-cbas";
};
keyboard-controller { keyboard-controller {
compatible = "google,cros-ec-keyb-switches"; compatible = "google,cros-ec-keyb-switches";
}; };
......
...@@ -937,10 +937,6 @@ usbc_extcon: extcon0 { ...@@ -937,10 +937,6 @@ usbc_extcon: extcon0 {
google,usb-port-id = <0>; google,usb-port-id = <0>;
}; };
cbas {
compatible = "google,cros-cbas";
};
typec { typec {
compatible = "google,cros-ec-typec"; compatible = "google,cros-ec-typec";
#address-cells = <1>; #address-cells = <1>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment