Commit 050552cb authored by Darrick J. Wong's avatar Darrick J. Wong

xfs: fix some memory leaks in log recovery

Fix a few places where we xlog_alloc_buffer a buffer, hit an error, and
then bail out without freeing the buffer.
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
parent f368b29b
...@@ -1342,10 +1342,11 @@ xlog_find_tail( ...@@ -1342,10 +1342,11 @@ xlog_find_tail(
error = xlog_rseek_logrec_hdr(log, *head_blk, *head_blk, 1, buffer, error = xlog_rseek_logrec_hdr(log, *head_blk, *head_blk, 1, buffer,
&rhead_blk, &rhead, &wrapped); &rhead_blk, &rhead, &wrapped);
if (error < 0) if (error < 0)
return error; goto done;
if (!error) { if (!error) {
xfs_warn(log->l_mp, "%s: couldn't find sync record", __func__); xfs_warn(log->l_mp, "%s: couldn't find sync record", __func__);
return -EFSCORRUPTED; error = -EFSCORRUPTED;
goto done;
} }
*tail_blk = BLOCK_LSN(be64_to_cpu(rhead->h_tail_lsn)); *tail_blk = BLOCK_LSN(be64_to_cpu(rhead->h_tail_lsn));
...@@ -5300,7 +5301,8 @@ xlog_do_recovery_pass( ...@@ -5300,7 +5301,8 @@ xlog_do_recovery_pass(
} else { } else {
XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW,
log->l_mp); log->l_mp);
return -EFSCORRUPTED; error = -EFSCORRUPTED;
goto bread_err1;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment