Commit 0518e914 authored by Steen Hegelund's avatar Steen Hegelund Committed by Paolo Abeni

net: microchip: sparx5: Use chain ids without offsets when enabling rules

This improves the check performed on linked rules when enabling or
disabling them.  The chain id used must be the chain id without the offset
used for linking the rules.
Signed-off-by: default avatarSteen Hegelund <steen.hegelund@microchip.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 38f6408c
...@@ -1649,10 +1649,8 @@ bool vcap_is_next_lookup(struct vcap_control *vctrl, int src_cid, int dst_cid) ...@@ -1649,10 +1649,8 @@ bool vcap_is_next_lookup(struct vcap_control *vctrl, int src_cid, int dst_cid)
if (vcap_api_check(vctrl)) if (vcap_api_check(vctrl))
return false; return false;
/* The offset must be at least one lookup, round up */ /* The offset must be at least one lookup so round up one chain */
next_cid = src_cid + VCAP_CID_LOOKUP_SIZE; next_cid = roundup(src_cid + 1, VCAP_CID_LOOKUP_SIZE);
next_cid /= VCAP_CID_LOOKUP_SIZE;
next_cid *= VCAP_CID_LOOKUP_SIZE;
if (dst_cid < next_cid) if (dst_cid < next_cid)
return false; return false;
...@@ -2177,12 +2175,13 @@ static int vcap_get_next_chain(struct vcap_control *vctrl, ...@@ -2177,12 +2175,13 @@ static int vcap_get_next_chain(struct vcap_control *vctrl,
static bool vcap_path_exist(struct vcap_control *vctrl, struct net_device *ndev, static bool vcap_path_exist(struct vcap_control *vctrl, struct net_device *ndev,
int dst_cid) int dst_cid)
{ {
int cid = rounddown(dst_cid, VCAP_CID_LOOKUP_SIZE);
struct vcap_enabled_port *eport = NULL; struct vcap_enabled_port *eport = NULL;
struct vcap_enabled_port *elem; struct vcap_enabled_port *elem;
struct vcap_admin *admin; struct vcap_admin *admin;
int tmp; int tmp;
if (dst_cid == 0) /* Chain zero is always available */ if (cid == 0) /* Chain zero is always available */
return true; return true;
/* Find first entry that starts from chain 0*/ /* Find first entry that starts from chain 0*/
...@@ -2201,7 +2200,7 @@ static bool vcap_path_exist(struct vcap_control *vctrl, struct net_device *ndev, ...@@ -2201,7 +2200,7 @@ static bool vcap_path_exist(struct vcap_control *vctrl, struct net_device *ndev,
return false; return false;
tmp = eport->dst_cid; tmp = eport->dst_cid;
while (tmp != dst_cid && tmp != 0) while (tmp != cid && tmp != 0)
tmp = vcap_get_next_chain(vctrl, ndev, tmp); tmp = vcap_get_next_chain(vctrl, ndev, tmp);
return !!tmp; return !!tmp;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment