Commit 0527a04f authored by Ben Skeggs's avatar Ben Skeggs

drm/nouveau/core: prepare printk for NULL engine pointer on device object tree

The [  SUBDEV] specified in log output will be a bit different for
children of a subdev now.  Previously this reports whatever subdev
is specified by object.engine, now it reports the subdev that owns
the object (so, up object.parent somewhere).

Later patches will append object and class identifiers to messages,
which will help clarify where it's coming from.
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent e138c7d8
...@@ -60,21 +60,26 @@ nv_printk_(struct nouveau_object *object, int level, const char *fmt, ...) ...@@ -60,21 +60,26 @@ nv_printk_(struct nouveau_object *object, int level, const char *fmt, ...)
} }
if (object && !nv_iclass(object, NV_CLIENT_CLASS)) { if (object && !nv_iclass(object, NV_CLIENT_CLASS)) {
struct nouveau_object *device = object; struct nouveau_object *device;
struct nouveau_object *subdev = object; struct nouveau_object *subdev;
char obuf[64], *ofmt = ""; char obuf[64], *ofmt = "";
if (object->engine) { subdev = object;
while (subdev && !nv_iclass(subdev, NV_SUBDEV_CLASS))
subdev = subdev->parent;
if (!subdev)
subdev = object->engine;
device = subdev;
if (device->parent)
device = device->parent;
if (object != subdev) {
snprintf(obuf, sizeof(obuf), "[0x%08x]", snprintf(obuf, sizeof(obuf), "[0x%08x]",
nv_hclass(object)); nv_hclass(object));
ofmt = obuf; ofmt = obuf;
subdev = object->engine;
device = object->engine;
} }
if (subdev->parent)
device = subdev->parent;
if (level > nv_subdev(subdev)->debug) if (level > nv_subdev(subdev)->debug)
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment