Commit 054b2b13 authored by Joonwoo Park's avatar Joonwoo Park Committed by Linus Torvalds

pps: fix incorrect verdict check

Fix incorrect verdict check and returns error if device_create failed,
otherwise driver triggers kernel oops.

Signed-off-by: Joonwoo Park<joonwpark81@gmail.com>
Cc: Rodolfo Giometti <giometti@enneenne.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f415c413
...@@ -244,7 +244,7 @@ int pps_register_cdev(struct pps_device *pps) ...@@ -244,7 +244,7 @@ int pps_register_cdev(struct pps_device *pps)
} }
pps->dev = device_create(pps_class, pps->info.dev, pps->devno, NULL, pps->dev = device_create(pps_class, pps->info.dev, pps->devno, NULL,
"pps%d", pps->id); "pps%d", pps->id);
if (err) if (IS_ERR(pps->dev))
goto del_cdev; goto del_cdev;
dev_set_drvdata(pps->dev, pps); dev_set_drvdata(pps->dev, pps);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment