Commit 0649c61d authored by Jin Yao's avatar Jin Yao Committed by Greg Kroah-Hartman

perf report: Fix no libunwind compiled warning break s390 issue

[ Upstream commit c3314a74 ]

Commit 800d3f56 ("perf report: Add warning when libunwind not
compiled in") breaks the s390 platform. S390 uses libdw-dwarf-unwind for
call chain unwinding and had no support for libunwind.

So the warning "Please install libunwind development packages during the
perf build." caused the confusion even if the call-graph is displayed
correctly.

This patch adds checking for HAVE_DWARF_SUPPORT, which is set when
libdw-dwarf-unwind is compiled in.

Fixes: 800d3f56 ("perf report: Add warning when libunwind not compiled in")
Signed-off-by: default avatarJin Yao <yao.jin@linux.intel.com>
Reviewed-by: default avatarThomas Richter <tmricht@linux.ibm.com>
Tested-by: default avatarThomas Richter <tmricht@linux.ibm.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jin Yao <yao.jin@intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200107191745.18415-1-yao.jin@linux.intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0f7a3343
...@@ -383,10 +383,10 @@ static int report__setup_sample_type(struct report *rep) ...@@ -383,10 +383,10 @@ static int report__setup_sample_type(struct report *rep)
PERF_SAMPLE_BRANCH_ANY)) PERF_SAMPLE_BRANCH_ANY))
rep->nonany_branch_mode = true; rep->nonany_branch_mode = true;
#ifndef HAVE_LIBUNWIND_SUPPORT #if !defined(HAVE_LIBUNWIND_SUPPORT) && !defined(HAVE_DWARF_SUPPORT)
if (dwarf_callchain_users) { if (dwarf_callchain_users) {
ui__warning("Please install libunwind development packages " ui__warning("Please install libunwind or libdw "
"during the perf build.\n"); "development packages during the perf build.\n");
} }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment