lab.nexedi.com will be down from Thursday, 20 March 2025, 07:30:00 UTC for a duration of approximately 2 hours

Commit 066f40dc authored by Vivek Goyal's avatar Vivek Goyal Committed by Greg Kroah-Hartman

ovl: Pass ovl_get_nlink() parameters in right order

commit 08d8f8a5 upstream.

Right now we seem to be passing index as "lowerdentry" and origin.dentry
as "upperdentry". IIUC, we should pass these parameters in reversed order
and this looks like a bug.
Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
Acked-by: default avatarAmir Goldstein <amir73il@gmail.com>
Fixes: caf70cb2 ("ovl: cleanup orphan index entries")
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c5ae6a3
...@@ -437,7 +437,7 @@ int ovl_verify_index(struct dentry *index, struct path *lowerstack, ...@@ -437,7 +437,7 @@ int ovl_verify_index(struct dentry *index, struct path *lowerstack,
/* Check if index is orphan and don't warn before cleaning it */ /* Check if index is orphan and don't warn before cleaning it */
if (d_inode(index)->i_nlink == 1 && if (d_inode(index)->i_nlink == 1 &&
ovl_get_nlink(index, origin.dentry, 0) == 0) ovl_get_nlink(origin.dentry, index, 0) == 0)
err = -ENOENT; err = -ENOENT;
dput(origin.dentry); dput(origin.dentry);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment