Commit 06bc4d00 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller

net: lantiq: Fix returned value in case of error in 'xrx200_probe()'

Return 'err' in the error handling path instead of 0.
Return explicitly 0 in the normal path, instead of 'err', which is known
to be 0 at this point.

Fixes: fe1a5642 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 761f6026
...@@ -512,7 +512,8 @@ static int xrx200_probe(struct platform_device *pdev) ...@@ -512,7 +512,8 @@ static int xrx200_probe(struct platform_device *pdev)
err = register_netdev(net_dev); err = register_netdev(net_dev);
if (err) if (err)
goto err_unprepare_clk; goto err_unprepare_clk;
return err;
return 0;
err_unprepare_clk: err_unprepare_clk:
clk_disable_unprepare(priv->clk); clk_disable_unprepare(priv->clk);
...@@ -520,7 +521,7 @@ static int xrx200_probe(struct platform_device *pdev) ...@@ -520,7 +521,7 @@ static int xrx200_probe(struct platform_device *pdev)
err_uninit_dma: err_uninit_dma:
xrx200_hw_cleanup(priv); xrx200_hw_cleanup(priv);
return 0; return err;
} }
static int xrx200_remove(struct platform_device *pdev) static int xrx200_remove(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment